Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI - check for real if proto-derived files are up to date #6747

Merged
merged 10 commits into from
Sep 27, 2024
Merged

CI - check for real if proto-derived files are up to date #6747

merged 10 commits into from
Sep 27, 2024

Conversation

pavoljuhas
Copy link
Collaborator

  • Rename check script build-changed-protos --> protos-up-to-date
  • Excise unused code for getting base revision
  • Exit with error status if dev_tools/build-protos.sh changes any content
  • Fail the CI if generated protos are not up to date

@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (756abe3) to head (c3fd3dc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6747   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files        1077     1077           
  Lines       92558    92558           
=======================================
  Hits        90555    90555           
  Misses       2003     2003

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavoljuhas
Copy link
Collaborator Author

pavoljuhas commented Sep 27, 2024 •
edited
Loading

Confirming that CI can now detect

Ready for review.

@pavoljuhas pavoljuhas marked this pull request as ready for review September 27, 2024 15:51
mhucka
mhucka approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pavoljuhas pavoljuhas merged commit 3a87b33 into quantumlib:main Sep 27, 2024
37 checks passed
@pavoljuhas pavoljuhas deleted the ci-check-protos-for-real branch September 27, 2024 18:00
@pavoljuhas pavoljuhas mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhucka mhucka mhucka approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney wcourtney is a code owner

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@verult verult Awaiting requested review from verult verult is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavoljuhas @mhucka